Item editor had not changed only the comment?

About: 401 authorization required

test

Tags

  1. new tag
  2. anything with tag in it

Comments


Mark de LA says
Upper case allowed in tags now?yes

Seth says
incidentally ... in this phase, i think we still want to focus on what does work ... rather than making a list of what does not.  

Seth says
MR 2015-12-12 09:53:47 [item 19173]
Upper case allowed in tags now?yes

it was not intended, unless match is case insensitive -- ok it works that way ... yes an improvement yes


special characters, which should be allowed and eliminated

Si says
seth 2015-12-12 09:56:53 [item 19173]
incidentally ... in this phase, i think we still want to focus on what does work ... rather than making a list of what does not.  
Yes. If there is one clean place to put things that don't work, so that I can sometime check them off (with the strikethrough feature) that would be great.
But in general I am moving along working big features down. Right now I just got the item editor working for existing items. The new item editor next and is a rather large project compared to the rest. I haven't done any work on tags, they either work by default of old code or they don't work. Things like that the input box needs to enforce lower case are good to know though. smiley

Ha! Seth's killEvilTag function stripped the strikethroughs!~ [fixed that ... gonna have to audit that feature]

Seth says
MR 2015-12-12 09:53:47 [item 19173]
Upper case allowed in tags now?yes
seth 2015-12-12 10:05:54 [item 19173]

it was not intended, unless match is case insensitive -- ok it works that way ... yes an improvement yes


special characters, which should be allowed and eliminated

actually, yes, it may have always been this way.   i'd have to check it on the old server.

Seth says

Ha! Seth's killEvilTag function stripped the strikethroughs!~

i did a whole lot of gucking around to try to eliminate people inserting evil HTML ... i am not sure if that is all still valid ... but i do know that people will still try to do it.

Seth says

Ha! Seth's killEvilTag function stripped the strikethroughs!~ [fixed that ... gonna have to audit that feature]

nathan

i did a whole lot of gucking around to try to eliminate people inserting evil HTML ... well people will still try to do that ... so i don't think that can be eliminated ... er, can it?

Seth says

woopse, some examples of editing being lost are happening

try this editing

Seth says

well it might be eliminating the new quoting too

let us see if it gets this one ...

Mark de LA says
I like the cleaner reading on all 3 browsers - ie where you can get rid of extra stuff to the sides of a main body. I use it to get white on black which is easier on my eyes.  Might be good to implement here however that is done.

Si says
seth 2015-12-12 10:19:54 [item 19173]

woopse, some examples of editing being lost are happening

try this editing
I lost a couple of edits when I edited something that someone was quoting at the same time. Their quote replaced the one I was editing on. The edits are still there on the now hidden item. smiley

That particular scenario I don't have an immediate solution for.

Seth says
seth 2015-12-12 10:27:55 [item 19173]
  the screen before  i pressed save

but note how it got shown (see above) ...
when i inserted inside a quote, the quoteing HTML  apparently got stripped away

Mark de LA says

THe search for the word global should have lots of items . No item list anymore?

Si says
MR 2015-12-12 10:31:50 [item 19173]

THe search for the word global should have lots of items . No item list anymore?
seth 2015-12-12 10:34:05 [item 19173]

ok we will get to that one
Searches and tags are down the list behind finishing all editors.

Seth says
seth 2015-12-12 10:18:25 [item 19173]

Ha! Seth's killEvilTag function stripped the strikethroughs!~ [fixed that ... gonna have to audit that feature]

nathan

i did a whole lot of gucking around to try to eliminate people inserting evil HTML ... well people will still try to do that ... so i don't think that can be eliminated ... er, can it?
nathan 2015-12-12 10:28:02 [item 19173]
No. It is a must. But I only added in your function this morning for the ajax posts and then now discovered that you are not allowing for all useful HTML5 tags. I simply need to audit the feature for proper tags ... the feature itself is necessary and your implementation is fine.
smileyyes

Seth says
seth 2015-12-12 10:27:55 [item 19173]
  the screen before  i pressed save
seth 2015-12-12 10:29:17 [item 19173]
but note how it got shown (see above) ...
when i inserted inside a quote, the quoteing HTML  apparently got stripped away

this is a current problem for you, right?

interesting too that editing the property of the image in the quoted dialogue got eliminated ... i had put a boarder around my screen scrape and put it on the right ... but i think you told me about that already

Seth says
seth 2015-12-12 10:27:55 [item 19173]
 
  a screen scrape before  i pressed save

notice what it ended up being in "2015-12-12 10:21:30"

this, me thinks, is a in the area you are workin

Si says
seth 2015-12-12 10:27:55 [item 19173]
  the screen before  i pressed save
seth 2015-12-12 10:29:17 [item 19173]
but note how it got shown (see above) ...
when i inserted inside a quote, the quoteing HTML  apparently got stripped away
seth 2015-12-12 10:43:12 [item 19173]
this is a current problem for you, right?

interesting too that editing the property of the image in the quoted dialogue got eliminated ... i had put a boarder around my screen scrape and put it on the right ... but i think you told me about that already
These may be the cleanEvilTags() function removing formatting from the post that ckedit is adding. I think I will disable that feature for now until it gets a full audit. In the mean time, be nice with your html. devil

Seth says

got it yes  ... nobody can get into this server without authentication anyway.